search

aardappel / procrastitracker

a Windows time tracking application
http://strlen.com/procrastitracker/
510 stars 54 forks source link

System crush on system tray icon double click #55

Open chaosdrop opened 5 years ago

chaosdrop commented 5 years ago

I'll preface this with the fact that my system hasn't ever crashed for any other reason, nor have had any other issues and is very stable.

Every so often if I double click the ProcrastiTracker system tray icon rather than right click it. (I forget get that double clicking doesn't just open the main window as that's how everything else I have in the tray area works. XD) The system will crash. No BSOD just screen freeze death.

The first few times it happened I just thought it was a random fluke, but figured I'd try not to risk it and just put a sticky note at the side of my screen to always use the right click and I went an entire month solid up time with zero issues, then someone removed my sticky note and I accidentally double clicked it, and the system froze and crashed. So at this point I'm pretty sure double clicking the ProcrastiTracker system tray Icon can crash a windows 10 system.

aardappel commented 5 years ago

Hmm.. I'm on Windows 10, and never seen this, nor heard it from any other users.

Also note that double-left or right click executes exactly the same code (!): https://github.com/aardappel/procrastitracker/blob/master/src/procrastitracker.cpp#L321 So if one crashes and the other doesn't, it must be some external factor.

Of course, I could simply disable double left, but I remember adding it simply because people reported that they were expecting something to happen.

chaosdrop commented 5 years ago

I was really thinking the same thing too, but it's the only thing that crashes the system, and well it's not consistent in that it happens every time, it's very consistently the only thing that crashes the system.

Now that you mention it though it might be the "double" click so it could be something about running the code twice that's causing the issue? Pretty much all the tray icons I use require a double click to bring up the main window. A single click either dose nothing or brings up a different menu on them. Whereas I'm not in the habit of double right clicking anything ever.

So it's very possible it's just the collection or programs I run that has me trained to double left click system tray icons that's causing the issue. XD

aardappel commented 5 years ago

It's not running the code twice.. as you can see from the code, the code only triggers when the 2nd click has already happened.

Like I said, I can't make it crash here, double-clicking like mad, and you're the first user to report it.. so it is likely something system specific.