search

aardappel / treesheets

TreeSheets : Free Form Data Organizer (see strlen.com/treesheets)
zlib License
2.5k stars 185 forks source link

Do not copy folded grids to clipboard #591

Closed tobiolo closed 5 months ago

aardappel commented 5 months ago

So now "copy" does not copy folded cells but "export" does? That might be confusing to the user. What is the reason behind not wanting to copy folded cells?

tobiolo commented 5 months ago

The main reason for me is what the user may expect in my eyes: If the cell has a folded grid, the user does not see the folded grid in the UI. So when the users copies to the clipboard, it should be consistent with what is displayed. If the user also wants to copy the folded grid, the user may unfold it; so it is copied to the clipboard what the user "sees". Do you agree? With export it is maybe more the expectation that it should include everything. The use case is especially for the situation where large stuff of content is folded and it should not be copied all to the clipboard because the user just wanted to copy at the higher (hierarchy) level and the stuff is intentially hidden away with the fold.

aardappel commented 5 months ago

I'm not sure if I agree that is what the user would expect. A user could expect either one, and not getting the folded cells when you expect them seems more problematic than getting the folded cells when you don't expect them. And then having no way to override that behavior.

If you get folded cells you didn't want you can delete them, if you are missing your folded cells you wanted you have to do the action again. Or if you don't notice, you now have a bad copy.

Did anyone complain about this behavior?

We could have a way to choose this behavior, but that is unnecessary complex UI.

Seems what we had before was on average better.

tobiolo commented 5 months ago

I'm not sure if I agree that is what the user would expect. A user could expect either one, and not getting the folded cells when you expect them seems more problematic than getting the folded cells when you don't expect them. And then having no way to override that behavior.

If you get folded cells you didn't want you can delete them, if you are missing your folded cells you wanted you have to do the action again. Or if you don't notice, you now have a bad copy.

Did anyone complain about this behavior?

We could have a way to choose this behavior, but that is unnecessary complex UI.

Seems what we had before was on average better.

Ok, thanks for your reply. I can understand the reasoning and I will close this PR then.