Comment is no longer valid

aardappel / treesheets

TreeSheets : Free Form Data Organizer (see strlen.com/treesheets)

zlib License

2.49k stars 184 forks source link

Comment is no longer valid #629

Open tobiolo opened 2 months ago

tobiolo commented 2 months ago

Issue solved with https://github.com/wxWidgets/wxWidgets/pull/24505

But it makes sense to keep the changes and not to pack the data objects into a composite object only to unpack it later.

aardappel commented 2 months ago

These kinds of fixes are not available in the minimum wxWidgets version we support yet, right? So some people building or even looking at the code may still have the problem. Thus, to be totally correct, it be better to say that this is a problem which was fixed in $date version of wxWidgets. Only when we require a minimum version of wxWidgets to build against that does not have the bug should the code pretend there is no problem.

tobiolo commented 2 months ago

Thanks for your feedback. Then it is really better to wait for the next release version. I would like to keep this PR open as a reminder then.