aardappel / treesheets

TreeSheets : Free Form Data Organizer (see strlen.com/treesheets)
zlib License
2.63k stars 194 forks source link

There is no indication of shortcuts in the menu... #688

Open qua-rus opened 3 months ago

qua-rus commented 3 months ago

Edit > Selection... >

Снимок_20240801_124913

Edit > Text Editing... >

Снимок_20240801_125107

View >

Снимок_20240801_125200

aardappel commented 3 months ago

These are visible in English, so it may have something to do with the localization?

qua-rus commented 3 months ago

Maybe, but I don't know where to look...

tobiolo commented 3 months ago

I can confirm that the accelerators are not displayed for the menu entries indicated above - Tested it with locale set to English, C, German, Russian...

tobiolo commented 3 months ago

But this is due to technical debt on the GTK side: https://docs.wxwidgets.org/latest/classwx_menu_item.html#a8b0517fb35e3eada66b51568aa87f261 image These accelerator keys (like Tab, but also Right, Left, Down etc.) are not supported by GTK so it is logical for wxWidgets to suppress the display of the accelerator keys on wxGTK, although TreeSheets implements them manually.

tobiolo commented 3 months ago

So as long a) these accelerator keys are not supported in wxGTK for menu items, thus making it right to suppress their display in the menu items AND b) we implement them manually it should be as-is today because wxWidgets cannot expect programmers work around the limitation as it is done by TreeSheets?

aardappel commented 3 months ago

I guess the most useful thing of shortcuts showing up there is for users to learn the keys.

If we wanted to display them anyway, maybe we could make a function that does if wxgtk: "{name} ({key})" else: "{name}\t{key}" ?

tobiolo commented 3 months ago

I guess the most useful thing of shortcuts showing up there is for users to learn the keys.

If we wanted to display them anyway, maybe we could make a function that does if wxgtk: "{name} ({key})" else: "{name}\t{key}" ?

That seems a valid approach to me, too.