search

aardappel / treesheets

TreeSheets : Free Form Data Organizer (see strlen.com/treesheets)
zlib License
2.64k stars 194 forks source link

[macOS] multiple issues in '11825716028' release #758

Closed core-code closed 2 weeks ago

core-code commented 2 weeks ago

previous macOS versions had proper version numbers that could be inspected in the Finder, both CFBundleVersion and CFBundleShortVersionString. in the new release both version numbers are missing.

the previous releases were proper universal binaries for both Intel and ARM Macs. the new one only works on ARM Macs.

the previous releases properly annotated its minimum system requirements ( LSMinimumSystemVersion ) as 10.15. the new release will just misbehave when launched on an "too early" system.

it basically looks like the whole Info.plist got replaced with a non-functioning in the new release. since "CFBundleDocumentTypes" is also missing now, it is unclear if double-clicking saved files will still work.

also, the bundle identifier changed from dot3labs.TreeSheets to com.strlen.TreeSheets and the name changed from TreeSheets to treesheets, was this on purpose?

core-code commented 2 weeks ago
Screenshot 2024-11-14 at 11 26 45 Screenshot 2024-11-14 at 11 26 39
aardappel commented 2 weeks ago

@tobiolo

tobiolo commented 2 weeks ago

I readded some of the missing nodes in the Plist, see https://github.com/aardappel/treesheets/pull/759

tobiolo commented 2 weeks ago

I guess the identifier can be the reverse DNS, so I took the one from the official homepage, same as for the FlatPak.

core-code commented 2 weeks ago

thanks. i see the "11842730555" release is better than the last try. i can confirm that the issue with the version numbers has been resolved.

however: 1.) this is still a AppleSilicon-only build while releases prior to 11825716028 did run fine on Intel-Macs too 2.) it was compiled against the macOS 14 SDK so this won't even run on macOS 13: Screenshot 2024-11-14 at 22 34 55

aardappel commented 2 weeks ago

MacOS 13 is from 2013.. I am not sure how much sense it makes for us to support OSes that far back unless it was trivial.

We should probably still support Intel if possible, though, if this is possible on CI.

core-code commented 2 weeks ago

i am talking about macOS 13 not Mac OS 10.13.

i.e. it will not run on systems that did not do this years macOS 15 and last years macOS 14 upgrade

aardappel commented 2 weeks ago

I was talking about neither, I was referring to the Darwin version haha. Apple made a nice mess of versioning.

But yes we should support a 2022 OS.

core-code commented 2 weeks ago

Apple made a nice mess of versioning.

indeed, and everything else too ;-)

tobiolo commented 2 weeks ago

Does it work now with the latest release?

core-code commented 2 weeks ago

all seems fine now, it is again an universal binary and should work back to 10.15. thanks