aardgoose / CaveView.js

Web native 3d cave survey viewer
https://aardgoose.github.io/CaveView.js/
MIT License
44 stars 11 forks source link

Reding models without centerline #15

Open ariaveta opened 5 years ago

ariaveta commented 5 years ago

Hello, I would like to combine a cave survey with various surface models, so I generated a surface model without centerline inside and I tried to display it with CaveView. Unfortunately I got:

CaveView.js:44110 Uncaught TypeError: Cannot read property 'geometry' of undefined at new Topology (CaveView.js:44110) at Survey.loadCave (CaveView.js:46816) at new Survey (CaveView.js:46616) at CaveLoader.caveLoaded$1 [as callback] (CaveView.js:51719) at CaveLoader.callHandler (CaveView.js:42922) at FileReader._loaded (CaveView.js:42878)

Same issue if I generate, for example, a model with only entrance station, without centerline.

You can see issues here:

http://www.speleotoscana.it/3d-test

if you try to display last two models (Surface only and Entrance Only). Another issue is on the same page if I try to display the first model (Apuane ortofoto) using Firefox:

ReferenceError: event is not defined[Learn More] CaveView.js:42828:4

It works with Chrome.

aardgoose commented 5 years ago

Hi,

There problems should be fixed by 1.13.1

ariaveta commented 5 years ago

Thanks, I already tested it.

http://www.speleotoscana.it/3d-test

Try to select 'Apuane ortofoto' and 'Surface only'

Thanks, Marco

Il giorno mer 23 gen 2019 alle ore 16:52 aardgoose notifications@github.com ha scritto:

Hi,

There problems should be fixed by 1.13.1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aardgoose/CaveView.js/issues/15#issuecomment-456854551, or mute the thread https://github.com/notifications/unsubscribe-auth/ACLZD6Dst3qqdFtU2FlBfbHNC6wp4drIks5vGIVFgaJpZM4aJFAk .

aardgoose commented 5 years ago

I'm not sure what problem you are seeing?

I can see some console errors caused by the method the web server is sending the files which I have fixed and you are using loadCave() to clear the display, which causes some console errors. I now have added a CV.UI.clearView() method to clear the display without errors for this use case.

You are also hitting the restriction of loading multiple file types at once (.lox & .plt).

A test version at https://aardgoose.github.io/CaveView.js/test.html now allows multiple file types, that you can test. (Drag and drop with multiple files).