search

aardvark-platform / aardvark.docs

Simple examples combining multiple packages provided by the aardvark platform. Each platform repository comes with separate examples -- here we collect overarching examples using for example aardvark.rendering and aardvark.media.
https://aardvarkians.com/
MIT License
109 stars 5 forks source link

WIP: fix the build #32

Closed naartjie closed 3 years ago

haraldsteinlechner commented 3 years ago

CI is still failing because of missing chmod +x?

haraldsteinlechner commented 3 years ago

but your other PR fixes the problem, right?

naartjie commented 3 years ago

@haraldsteinlechner I created #33 just to check, and it is green:

https://ci.appveyor.com/project/stefanmaierhofer/aardvark-docs/builds/35447824

Screenshot 2020-09-28 at 16 57 07
haraldsteinlechner commented 3 years ago

cool. i think both of your pr's in combo fixed it :)

Marcin Jekot notifications@github.com schrieb am Mo., 28. Sep. 2020, 18:00:

@haraldsteinlechner https://github.com/haraldsteinlechner I created #33 https://github.com/aardvark-platform/aardvark.docs/pull/33 just to check, and it is green:

https://ci.appveyor.com/project/stefanmaierhofer/aardvark-docs/builds/35447824 [image: Screenshot 2020-09-28 at 16 57 07] https://user-images.githubusercontent.com/514563/94457135-13048c80-01ac-11eb-9b68-4aa1beb6d8ee.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aardvark-platform/aardvark.docs/pull/32#issuecomment-700127443, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5KAI6OLDIC2GK7MLYCN3SICXLPANCNFSM4R3SHPTA .

naartjie commented 3 years ago

Indeed, I meant to chmod +x in this one, but my 2 PR's got intertwined somehow

haraldsteinlechner commented 3 years ago

i suspected this, that is why i merged both. thanks

Marcin Jekot notifications@github.com schrieb am Mo., 28. Sep. 2020, 18:05:

Indeed, I meant to chmod +x in this one, but my 2 PR's got intertwined somehow

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aardvark-platform/aardvark.docs/pull/32#issuecomment-700129902, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5KALIMY7DY2PVNM6MBSTSICX3JANCNFSM4R3SHPTA .