search

aardvark-platform / aardvark.fake

Script extensions for FAKE build scripts such as native dependency injection and cabal style add-source functionality
Apache License 2.0
1 stars 2 forks source link

createPackage not finding build output #2

Open juagicre opened 7 years ago

juagicre commented 7 years ago

"build" is overruling the OuputPath to "bin\Release", but "createPackage" is taking the OutputPath of the project file to look for the binaries.

This means, if the OutputPath is not the same than that overruled by build, createPackage will fail. A more robust way to find the binaries should be used to support having projects that build to a custom directory.

haraldsteinlechner commented 7 years ago

At first glance i don't know how to provide such a robust output path mechanism... what is the reason your are using a custom build output path for some project?

juagicre commented 7 years ago

It's okay for us now to have it built to \bin\release, but since this is something that's actually enforced by the build command, why are the files for the package not also been taken from this hardcoded output path?

haraldsteinlechner commented 7 years ago

ok after looking into this i found that this is a non issue!?! since the output path for pack simply is defined by the paket.template files, e.g. ....\bin\Release\Aardvark.Base.Rendering.dll ==> lib\net45 arguments for the pack command can be found here: https://fsprojects.github.io/Paket/paket-pack.html

Aardvark.Fake is an extension to standard paket toolchain. for our purposes we simple provide convinience entry points in aardvark.fake.

you can also use your own targets in compile which do not overrule the output path and fiddle it out in paket.template. documentation for fake targets and msbuild is here: http://fsharp.github.io/FAKE/apidocs/fake-msbuildhelper.html

luithefirst commented 7 years ago

Thank you for looking into this, we figured that out then, at first we though it was the project output path since we configured it to that in the beginning. So might it be sufficient to only write the filenames without the full relative path into the template? The ouput directory should be known? Or are there cases where you want to include files outside the "build output"?

haraldsteinlechner commented 7 years ago

you can do this in your project, you are free to use your own path resolution sheme - am i right or has this side effects on aardvark platform projects?