search

aaren / notedown

Markdown <=> IPython Notebook
BSD 2-Clause "Simplified" License
855 stars 115 forks source link

Fixes: #61. Allows subsequent text blocks. #62

Open ioggstream opened 7 years ago

ioggstream commented 7 years ago

What does this PR do?

Allows subsequent code and text blocks.

Reimplements text and code block merging tracking position.

ioggstream commented 7 years ago

closed for recheck

aaren commented 7 years ago

hey @ioggstream, thanks for the PR! Could you modify the tests so that they fail before this change and pass after?

ioggstream commented 7 years ago

@aaren I submitted two patches in one. I will split this patch so that it does not modify the behavior of the code.

ioggstream commented 7 years ago

@aaren prerequisite patch https://github.com/aaren/notedown/pull/63

ioggstream commented 7 years ago

@aaren fixed this PR: now it has the same output testcase than before.

aaren commented 7 years ago

I mean can you add something to tests.py that causes it to fail before this PR and to pass afterwards? I don't fully understand what this PR is fixing, as I think subsequent code blocks are already supported.