search

aargirakis / BZRPlayer

Audio player for Windows that plays over 650 different fileformats
http://bzrplayer.blazer.nu/
GNU General Public License v3.0
10 stars 0 forks source link

tracks splitted in two subsongs #127

Open ciros88 opened 2 years ago

ciros88 commented 2 years ago

sum of two subsongs length is the real mod length cls toon 8.zip

ciros88 commented 2 years ago

also with this: anarchy.zip and i suppose with many others..

aargirakis commented 2 years ago

Well, what program are you comparing with? I tried BZR Player 1.06 with libxmp and its exactly the same result as in v2 with libopenmpt. And you mean this was different in 2.15?

ciros88 commented 2 years ago

ur right, my fault: it isnt a regression. but yeah, the behaviour seem incorrect. hippoplayer and deliplayer behave the same as bzr. normally you can distinguish mods with parts done to be recognized as subsongs because they make sense (an ingame track with the level completed subsong, or the various pinball tracks they mix linked to various bonuses, etc). but these sunsongs seems nonsense: mods.zip i need to better investigate

ciros88 commented 1 year ago

also this:

universal_network_2.zip

ciros88 commented 1 year ago

the cause of this behaviour in all mods.zip tracks is the Bxx (jump) command: libopenmpt provide a futher subsong that contains all the patterns which would never play if the loop were active. https://forum.openmpt.org/index.php?topic=6331.0

actual behaviour: track is splitted in subsongs: the main, unlooped, and the second, never reached if loop were active

desidered behaviour (to add in libopenmpt preferences):

1) play unlooped ignoring unplayed parts: ignore endless loops, and ignore also the unplayed part, that means do not display the further subsongs but only one playlist entry

2) follow loops and display unplayed part as another subsong: enable loops, then display also unplayed parts as further subsongs

in my opinion these behaviour are desidered for a player, and the first one should be the default, but also the second is really useful (sometimes i need it)

about universal_network_2.zip , the cause seems another (dunno for now).

aargirakis commented 11 months ago

As I understand if you enable "Loop Song" you will only get one subsong but the song will obviously loop. If you don't enable "Loop Song" you will get two subsongs, as it is now. I don't think I can do anything more about this?