aargirakis / BZRPlayer

Audio player for Windows that plays over 650 different fileformats
http://bzrplayer.blazer.nu/
GNU General Public License v3.0
10 stars 0 forks source link

Reduce default width of 'subsong' column #376

Closed ciros88 closed 5 months ago

ciros88 commented 1 year ago

realistically, the bigger value that could be displayed inside is a number which its number of digits is less than the number of column name chars (9999999 value -> 7 chars), so the default width should be, at least, equal (or smaller) than the column title width itself. having this, will help to reduce the overall columns width, having more room for columns like 'title' without necessarily making the bottom scroll bar appear

current behaviour: immagine

desidered behaviour: immagine

ciros88 commented 1 year ago

2.0.48.Alpha: the default width of 'subsong' column seem the same

aargirakis commented 1 year ago

Untitled-1 Maybe you have a playlist with a name that had previous old settings saved

ciros88 commented 1 year ago

to reproduce it: open a fresh (just installed) bzr2, drop a track (tried also with Compilation_III.sid), play it, and appears:

immagine

also: create a new playlist, then drop the track inside it then play: immagine

in first pic the width is too much, in the second pic the width is too shrinked (smaller than the SUBSONG text)

aargirakis commented 1 year ago

Ah ok, will take a look.

ciros88 commented 1 year ago

persists in 2.0.51.Alpha: 'LENGTH' and/or 'SUBSONG' column names have last letters cutted. also i've noticed that columns text is normal in default playlist but became BOLD in new playlist

image

image

aargirakis commented 1 year ago

OK, I will take a look again, but I think the issue mostly is that you don't have the font "Roboto" installed?

ciros88 commented 1 year ago

I have simply unzipped bzr2 and launched it with wine, without install nothing before

ciros88 commented 1 year ago

the two bugs (column width and bold issue) appears on windows also, where the roboto font is installed and correctly rendered),as you can see here:

immagine

immagine

so roboto is not the cause i suppose.

OK, I will take a look again, but I think the issue mostly is that you don't have the font "Roboto" installed?

i suppose we shouldn't rely on which fonts the user has installed on the system, instead we should provide everything needed embedded in the bzr2 dir, including the needed fonts.

aargirakis commented 1 year ago

I agree, but it's because of issue #296 that this maybe isn't working for you. It also looks like you have other size on your menubar than mine, did you change to bigger fonts in Windows settings?

ciros88 commented 1 year ago

Yeah i changed dpi (from 96 to 120) because at 3440x1440 resolution the text is too little

aargirakis commented 1 year ago

Well, that's the problem :)

ciros88 commented 1 year ago

Uhm seems i have the same problem with 96dpi (default) also

aargirakis commented 1 year ago

Yes, if you change dpi in Windows hell breaks loose, that's expected.

ciros88 commented 1 year ago

I have changed dpi from 96 to 120 in wine only, in Windows instead i havent touched it

aargirakis commented 11 months ago

So is this still an issue?

ciros88 commented 11 months ago

2.0.60.alpha:

aargirakis commented 10 months ago

I have 1920x1080 in Windows and where you can change "The size of text, apps, and other items" it says "100% (Recommended)" probably because it's a pain in the ass to support different font sizes, button sizes etc. It's a really big thing.

ciros88 commented 10 months ago

What i mean with "support" is not a dynamic size adapatation but simpy a static one. My idea is: put ur windows to 125% (120 dpi) or, better, 150% (144 dpi), see where the text overlaps or it is cutted then fix it.

aargirakis commented 10 months ago

Yes, but that's the thing. Then I will have to increase padding/margins/whitespace which will mean more waste of space when you use 100%.

ciros88 commented 10 months ago

It is possibile then to get the current screen dpi and choose the increase (of padding/margins/whitespace) based on it with static values? So no space wasting when not needed

ciros88 commented 5 months ago

will be closed since we can mitigate the problem with #368 and #469