Before these changes the PKGBUILD suggest in its name and pkgver that it would build a specific version. In reality it would build latest master.
To make it clear and get a more meaningful pkgver for the built package add pkgver() and rename the created package. These changes adopt the VCS packaging guidelines for Arch Linux: https://wiki.archlinux.org/title/VCS_package_guidelines
Another approach would be to build the specified tag: https://github.com/Narrat/octopi/commit/804544157f47a8f3bb4e1abb63658a3b3b8868d2
I opted for the VCS approach, as this PKGBUILD is located within the source repo and I assumed the intention is to get quickly a package for installation to test some changes.
Note that the source line uses the release archive. It could also be changed to use the tag: ${pkgname}-${pkgver}.tar.gz::https://github.com/aarnt/octopi/archive/refs/tags/v${pkgver}.tar.gz (which should also be used for the PKGBUILD hosted on the aurweb as omitting the pkgver (and to an extend the extension) in the downloaded source causes issues for users of SRCDEST as the name isn't unique)
aarnt
commented
5 months ago
Before these changes the PKGBUILD suggest in its name and pkgver that it would build a specific version. In reality it would build latest master. To make it clear and get a more meaningful pkgver for the built package add pkgver() and rename the created package. These changes adopt the VCS packaging guidelines for Arch Linux: https://wiki.archlinux.org/title/VCS_package_guidelines
Another approach would be to build the specified tag: https://github.com/Narrat/octopi/commit/804544157f47a8f3bb4e1abb63658a3b3b8868d2 I opted for the VCS approach, as this PKGBUILD is located within the source repo and I assumed the intention is to get quickly a package for installation to test some changes. Note that the source line uses the release archive. It could also be changed to use the tag:
${pkgname}-${pkgver}.tar.gz::https://github.com/aarnt/octopi/archive/refs/tags/v${pkgver}.tar.gz(which should also be used for the PKGBUILD hosted on the aurweb as omitting the pkgver (and to an extend the extension) in the downloaded source causes issues for users of SRCDEST as the name isn't unique)