Since v3.0.0 comment highlighting no longer works in Pascal

[mzwolsky]

Hi,

as the title says comment highlighting no longer works in ObjectPascal, but works in other languages:

I'm using both the Pascal Extension by Alessandro Fragnani and the OmniPascal Extension by Wosi for the language support. Using the previous version 2.1.0 both languages work:

Thank you for this great extension!

[Zxynine]

If you saw my last comment, disregard it, I went looking and it seems to be an issue with OmniPascal. I cant see the source code of it but Im willing to bet the problem is that It does not properly configure its language configuration for ObjectPascal (assuming it even uses it too much). Bettercomments can more than likley add in an exception for it but It would only solve this one case and no others. Without access to the .package file for OmniPascal I cant tell you for certain, but nothing ive seen in the code of BetterComments should conflict with properly set up languages.

If the creator wants to solve this I think just adding this code below to the switch expression in Parser.ts would fix it.

            case "objectpascal":
                this.supportedLanguage = true;
                this.setCommentFormat("//", "/*", "*/");

[aaron-bond]

Yeah this is most likely an issue with how the language extension declares comment format. I had hoped that when I created V3 we'd avoid any future language issues but I ended up just swapping one class of bugs for another. At least with the old (hard coded) way I had full control over the fixes. Now it requires me to reach out to other extension creators and propose a fix. I'll try to get this one verified locally and I'll reach out to the creators of the Pascal language extension if it turns out it's missing something. Thanks for the investigation here @mzwolsky @Zxynine

[mzwolsky]

Ah, I feared that would be the case. Thanks to both of you for your help @Zxynine @aaron-bond