After installing in Emacs 24.3, I noticed that rcirc-styles-insert-attribute was throwing on completion attempts with "Invalid function: (bold italic underline inverse)".
Triage reveals this to result from passing completing-read a collection candidate list of symbols, which try-completion in Emacs 24.4 is prepared to accept, but in prior versions apparently is not. The fix is simple: instead of mapping rcirc-styles-attribute-alist over #'cdr, map it over #'(lambda (pair) (symbol-name (cdr pair))), so that the result is a list of strings instead of a list of symbols.
For anyone affected who happens to see this before I get to fixing it, I intend to roll out the hotfix today as version 1.3.1, which means MELPA should have it in both stable and unstable by tomorrow. (Also, sorry for the trouble!)
aaron-em
commented
8 years ago
After installing in Emacs 24.3, I noticed that
rcirc-styles-insert-attributewas throwing on completion attempts with "Invalid function: (bold italic underline inverse)".Triage reveals this to result from passing
completing-reada collection candidate list of symbols, whichtry-completionin Emacs 24.4 is prepared to accept, but in prior versions apparently is not. The fix is simple: instead of mappingrcirc-styles-attribute-alistover#'cdr, map it over#'(lambda (pair) (symbol-name (cdr pair))), so that the result is a list of strings instead of a list of symbols.For anyone affected who happens to see this before I get to fixing it, I intend to roll out the hotfix today as version 1.3.1, which means MELPA should have it in both stable and unstable by tomorrow. (Also, sorry for the trouble!)