search

aarona / devise_jwt_auth

A JWT-based port of Devise Token Auth
Do What The F*ck You Want To Public License
7 stars 2 forks source link

Default refresh token path #10

Closed stereodenis closed 1 year ago

stereodenis commented 2 years ago

closes #9

aarona commented 2 years ago

This looks good. Can you include tests that cover overriding the default configuration setting?

When you run the tests: rake test you will have 32 failures currently. These are all OmniAuth tests complaining about a route not being found. I need figure out whats going on here eventually as these tests WERE passing before and I haven't touched the OmniAuth code because I haven't needed to use it. I might comment those tests out at some point and mention that OmniAuth isn't supported until I can find out the issue.

Anyway, if you could add some tests to cover this and when you run rake tests and get 32 errors related to: 

ActionController::RoutingError: No route matches [GET] "/omniauth/facebook"

Then your tests should be passing and I'll accept your PR.

aarona commented 1 year ago

I made a separate commit with the tests for this. I appreciate that you made this PR but next time please add tests for your commits.