search

aarona / devise_jwt_auth

A JWT-based port of Devise Token Auth
Do What The F*ck You Want To Public License
7 stars 2 forks source link

Rails >6.1 support #7

Closed stereodenis closed 2 years ago

stereodenis commented 2 years ago

Now it

  s.add_dependency 'rails', '>= 4.2.0', '< 6.1'
aarona commented 2 years ago

I can take a look at this today and get a new version this week.

stereodenis commented 2 years ago

@aarona cool! Will wait for it

aarona commented 2 years ago

Just a quick update. I figured out why I did this. There was a major version update of sprockets that I couldn't support. I'm going to push new major release of this gem (0.2.0) to support rails 7+, Sprockets 4 and remove ruby support for anything older than 2.6. There's a bunch errors and deprecation warnings (see Devise and issues related a new constant: UNSAFE_ATTRIBUTES_FOR_SERIALIZATION). Hoping to have a release of this for you later today. Its possible you may need to run Rails 7 for this to work for you.

Also, I appreciate your interest in this gem :+1:

aarona commented 2 years ago

Ok after some more research, I've discovered that minitest-rails has not finished updating for rails 7 and thats required for testing the gem. You'll have to sit tight for a while, @stereodenis until they are ready. I'll keep monitoring this and when everything is ready, I'll push a release. Thanks for bringing my attention to this!

stereodenis commented 2 years ago

@aarona maybe, we can just update gem for using on >6.1 and <7. What do you think?

aarona commented 2 years ago

Ok I see what you mean. I’m out of town for two days. When I get back I’ll make this change.

aarona commented 2 years ago

This gem has been updated to support Rails 6.1.4.4+. I having trouble getting OmniAuth tests to pass so no guarantee those will work with this version. I don't use OmniAuth with the project I'm currently using this gem with but if you'd like to take a stab at that issue, you're welcome to.