search

aaronbieber / sunshine.el

An Emacs package for displaying the forecast from OpenWeatherMap.
87 stars 15 forks source link

Colorscheme looks weird on default theme #5

Closed leafac closed 9 years ago

leafac commented 9 years ago

Great work! That's exactly what I was looking for!

But the colors are not looking good on my colorscheme:

sunshine

You can see there's only a low contrast in the title Forecast for Baltimore, United States of America and the name of the days, such as Tuesday, Jan. 27 don't even show up.

My setup is Prelude with the default zenburn theme disabled by (disable-theme 'zenburn) as described in the documentation. I disabled it because I prefer light backgrounds.

On an unrelated note, please release this as a package in MELPA :smile:

aaronbieber commented 9 years ago

Thanks for opening this issue. I am currently using a specific named color for that heading, which is not the right thing to do. It ought to be a color keyword that will select a color from your own theme, and I had that on my mental to-do list, but it's much better as a Github issue :+1:

leafac commented 9 years ago

Awesome! :heart:

I'm looking forward into seeing this in MELPA :smile:

leafac commented 9 years ago

Hi, @aaronbieber.

I'm going to close this issue for the following reasons:

  1. I'm using a dark colorscheme now and sunshine.el looks good in it.
  2. sunshine.el is on MELPA.
  3. It's stale.

Thanks for the project! I'm using it everyday :smile: