aaronbieber / sunshine.el

An Emacs package for displaying the forecast from OpenWeatherMap.
87 stars 15 forks source link

Added support for new Openweather APPID based calls #8

Closed azynheira closed 8 years ago

azynheira commented 8 years ago

It seems Openweather obligates the uses the register and a APPID is provided to each user. Since this APPID is mandatory in the webservice call, it needs to be added. Please check my pull request to add this functionality to sunshine.

Kind Regards

aaronbieber commented 8 years ago

This looks fine but can you please correct the spelling/grammar on the defcustom:

"You can get an APPID by logging into your OpenWeather account."

azynheira commented 8 years ago

Spelling correction done! Maybe some checks also could be in handy if no APPID is provided ? Only recalled this now :-)