aarond10 / https_dns_proxy

A lightweight DNS-over-HTTPS proxy.
MIT License
775 stars 114 forks source link

Update documentation to reference Docker install. #103

Closed moranbw closed 3 years ago

moranbw commented 3 years ago

I created a pretty basic Dockerfile that pulls from your repo and builds. I expose value-based flags as environment variables (i.e. DNS_SERVERS) and pure flags as cmd arguments (i.e. -4).

Perhaps running in a container is a fringe use case, but it seems to work well.

https://github.com/moranbw/https-dns-proxy-docker

aarond10 commented 3 years ago

Nice. Thanks for putting the image together. I've been a bit busy so haven't checked it out myself yet. Comment LGTM.

moranbw commented 3 years ago

Great! Lemme know if you have any feedback :)

moranbw commented 3 years ago

@aarond10 just realized I put the wrong link for Docker Image. I embedded link for my management view. Not public view. It should be this https://hub.docker.com/r/bwmoran/https-dns-proxy.

I can make another PR, whatever is easier for you.

aarond10 commented 3 years ago

A pull request would be great if you have the time, otherwise I'll have to look at it in a day or two.

On Fri, 26 Feb 2021 at 15:20, Brian Moran notifications@github.com wrote:

@aarond10 https://github.com/aarond10 just realized I put the wrong link for Docker Image. I embedded link for my management view. Not public view. It should be this https://hub.docker.com/r/bwmoran/https-dns-proxy.

I can make another PR, whatever is easier for you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aarond10/https_dns_proxy/pull/103#issuecomment-786400928, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABTOXVFHY5KA7HQCOBA6KDTA4OQZANCNFSM4YDSNTAA .