search

aarond10 / https_dns_proxy

A lightweight DNS-over-HTTPS proxy.
MIT License
779 stars 114 forks source link

setting GIT_VERSION for cmake options has no effect on version in the binary #173

Closed stangri closed 3 months ago

stangri commented 6 months ago

@aarond10 @baranyaib90 this issue has grown in importance since OpenWrt now mangles the PKG_RELEASE variable outside of the package's Makefile control for development branch, but not release branch.

I'm building the package not from git repo, but from the github archive and setting GIT_VERSION in the OpenWrt makefile, doesn't seem to affect anything so I ended up needing to create a patch which I update based on version from the Makefile with my own automation.

I wonder if it's some logic in the CMakeLists.txt that needs to be updated for the build process to pick up the value of GIT_VERSION when building from gzipped source rather than git checkout or if I'm doing something wrong, but if I could get rid of the patch and be able to set the version from the OpenWrt Makefile, it might make my life much easier maintaining the package for both development and release branches.

stangri commented 3 months ago

@aarond10 @baranyaib90 ping?

baranyaib90 commented 3 months ago

Hi, I'm sorry, but I don't have time anymore to support the project (https://github.com/aarond10/https_dns_proxy/pull/154#issue-1513166264). If I would send some improvements in the future, thats not because I'm fixing reported issues. It would be because I'm contributing the changes that I needed for myself. I would apprechiate if you won't mention me in the future in issues. Else I would have to unsubscribe from notifications entirely. Thank you for your understanding!

aarond10 commented 3 months ago

Sorry, I've been quite busy lately. I will do my best to have a look at this this week.

On Wed, 31 Jul 2024 at 16:48, baranyaib90 @.***> wrote:

Hi, I'm sorry, but I don't have time anymore to support the project (#154 (comment) https://github.com/aarond10/https_dns_proxy/pull/154#issue-1513166264). If I would send some improvements in the future, thats not because I'm fixing reported issues. It would be because I'm contributing the changes that I needed for myself. I would apprechiate if you won't mention me in the future in issues. Else I would have to unsubscribe from notifications entirely. Thank you for your understanding!

— Reply to this email directly, view it on GitHub https://github.com/aarond10/https_dns_proxy/issues/173#issuecomment-2259794317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABTOXRNDFEHC7THM7462ATZPCCDJAVCNFSM6AAAAABG3OEUNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJZG44TIMZRG4 . You are receiving this because you were mentioned.Message ID: @.***>

stangri commented 3 months ago

Sorry, don't have the time to dig up the commit, but either you or other contributors have addressed this, and setting SW_VERSION in CMAKE OPTIONS works!