search

aarondfrancis / fast-paginate

A fast implementation of offset/limit pagination for Laravel.
MIT License
1.21k stars 56 forks source link

Solved issue for orderByRaw functions. #51

Closed atapatel closed 1 year ago

atapatel commented 1 year ago

I solved this issue https://github.com/hammerstonedev/fast-paginate/pull/35.

atapatel commented 1 year ago

@aarondfrancis did you check this PR?

aarondfrancis commented 1 year ago

Yes, I did. I'll ask again over here: what is the issue?

I added a test to main and it didn't fail. So what is the failing test or use case?

atapatel commented 1 year ago

Give me 10 minute.

atapatel commented 1 year ago
image

php version is 8.1.18 laravel version is 9.52.6

atapatel commented 1 year ago

@aarondfrancis does the above snippet helpful?

atapatel commented 1 year ago

@aarondfrancis I have merged your PR in my local repository and run the test, and all the tests are passed. but when I use laravel, it gives me above mentioned deprecated error.

aarondfrancis commented 1 year ago

Merged #35 instead.

If you can produce a test case that requires this PR vs the one that just filters out the raw orders, I'll reopen this. Thanks for your help!