search

aarondfrancis / fast-paginate

A fast implementation of offset/limit pagination for Laravel.
MIT License
1.21k stars 56 forks source link

Add missing imports - discovered by PHPStan #6

Closed szepeviktor closed 2 years ago

szepeviktor commented 2 years ago

and fix @var tags

@aarondfrancis please consider performing static analysis.

aarondfrancis commented 2 years ago

Can you drop the larastan requirement? I'll merge after that. Thanks!

szepeviktor commented 2 years ago

Can you drop the larastan requirement?

Yes I can. It makes me stop contributing to this project.

szepeviktor commented 2 years ago

Done.

aarondfrancis commented 2 years ago

Thanks for your contributions.

I must say that your comments are not very kind, you might consider modifying that in the future.

aarondfrancis commented 2 years ago

Published v0.1.1 with the fix!

szepeviktor commented 2 years ago

I must say that your comments are not very kind

Thank you for your feedback!!

How should I phrase It makes me stop contributing to this project ?

aarondfrancis commented 2 years ago

Thanks for asking!

It was more the "Done. Goodbye 👋" that felt rude. You've already edited that out so you probably knew 😄

I understand written communication is sometimes missing nuance, which makes it tough!