search

aarondfrancis / fast-paginate

A fast implementation of offset/limit pagination for Laravel.
MIT License
1.21k stars 56 forks source link

Fix copy-pasta in BuilderMixin #7

Closed szepeviktor closed 2 years ago

szepeviktor commented 2 years ago

@aarondfrancis It was possible to discover this by performing static analysis.

aarondfrancis commented 2 years ago

I did that on purpose, actually 😄

That argument is useless because we're passing an explicit page in as the last param.

szepeviktor commented 2 years ago

The framework accepts a string in $pageName. What should we do?

szepeviktor commented 2 years ago

Could we put in the default value of "page"?

aarondfrancis commented 2 years ago

It doesn't really matter since it's short-circuited anyway, so we'll just pass it in!

aarondfrancis commented 2 years ago

Thanks for the PR!

szepeviktor commented 2 years ago

You're welcome.