Add return types and PHP generics

aarondfrancis / fast-paginate

A fast implementation of offset/limit pagination for Laravel.

MIT License

1.21k stars 56 forks source link

Closed szepeviktor closed 2 years ago

aarondfrancis commented 2 years ago

Thanks for the PR, but I don't want to add types to the package quite yet. I'm not personally a big fan of them.

szepeviktor commented 2 years ago

I'm not personally a big fan of them.

All right. Maybe later you develop a love-relation with typehints ❤️

aarondfrancis commented 2 years ago

Maybe later you develop a love-relation with typehints ❤️

Maybe so! Don't give up on me yet 😉