search

aarondoet / AccountSwitcher

BetterDiscord plugin to switch between multiple accounts
MIT License
229 stars 79 forks source link

Added Turkish language and formatted the code using Prettier #50

Open Veysinator opened 3 years ago

Veysinator commented 3 years ago

Added 1 language and made the code easier to read

aarondoet commented 3 years ago

While I'm not using a formatter I still have my own set of rules I usually follow and the formatter you used does not follow them. That is a change I don't want, if I decide to change formatting I will do it myself. And while it is nice that you added translations, they are currently not used inside the plugin. However I would merge a PR changing nothing but the translations file in case I will add translations again. It would probably use a few different messages but I should still be able to use several of the already existing translations.

Veysinator commented 3 years ago

While I'm not using a formatter I still have my own set of rules I usually follow and the formatter you used does not follow them. That is a change I don't want, if I decide to change formatting I will do it myself. And while it is nice that you added translations, they are currently not used inside the plugin. However I would merge a PR changing nothing but the translations file in case I will add translations again. It would probably use a few different messages but I should still be able to use several of the already existing translations.

Thank you for informing me, have a good day.