aarondoet / BetterDiscordStuff

all my stuff for betterdiscord
MIT License
154 stars 81 forks source link

[ChannelTabs] Issue: throws react error on context menu #161

Closed TheAwesome98-Real closed 1 year ago

TheAwesome98-Real commented 1 year ago

Describe the bug When a context menu that has ChannelTabs buttons in it is opened, a react error is thrown.

To Reproduce Steps to reproduce the behavior:

  1. Right click on anything with the plugin enabled

Expected behavior No exception is thrown and the context menu is opened.

Screenshots exception is minified so i don't think you'll need it?

Information (please complete the following information):

MichaelDavidGK commented 1 year ago

I believe that I once got non-minified error that said something about that it cannot take "group" when "object" is expected, anyway it is due to recent updates (1, 2)

Matt0040 commented 1 year ago

This issue happens with just about any plugin that affects the menu created when you right click a servers name, user name, anything to get some specific details like user ID. It took a long time but I was able to fix it, Channel Tabs obviously is one but others would be the BDContextMenu. The console reads something about the new API being unable to use children. If I weren't scared of fixing what's not broken I'd try to get a console log.

TL;DR Discord crashes whenever a plugin affecting context menus right clicks a user, server, almost anything from what I can tell.

TheAwesome98-Real commented 1 year ago

oh, i forgot, i did update discord to 0.22.0 recently

MichaelDavidGK commented 1 year ago

It has been fixed previously and now version number for BD has been changed to 1.8.4 to ensure everyone gets the fix: FIXED

As such this problem is fixed ;)

TheAwesome98-Real commented 1 year ago

fixed in betterdiscord 1.8.4