Support connecting to YOURLS API over HTTPS

dgw commented 8 years ago

It's easy for users to put in only the YOURLS domain, but API requests do use a secret token that should not be revealed in cleartext if it can be avoided. My YOURLS installation is available over HTTPS, and I'd like to eliminate insecure requests to it as much as possible.

I propose the following:

Better YOURLS continues to accept just the domain as a setting
Internally it's now treated as base_url instead of domain
On save, prepend http:// to the option if it is missing
Users can use an https:// value if they want
The option is validated by something like the regex https?:\/\/.+(\..+)+\.?(\/.*)*\/? \ This pattern allows for YOURLS installations accessed over HTTP or HTTPS, at the domain root or in subdirectories

ChrisWiegman commented 8 years ago

I'll have to look at this. I run admin on https myself but had some problems with the api calls.

ChrisWiegman commented 8 years ago

Well, got this working. Please take a look at https://github.com/ChrisWiegman/Better-YOURLS/tree/feature/allow_https and let me know what you think (it's always good to have a 2nd set of eyes on a requested feature).

ChrisWiegman commented 8 years ago

This has been pushed in 2.1

aaroneaton / better-yourls

Support connecting to YOURLS API over HTTPS #8