search

aaroneiche / do-want

Do Want - Open Source Gift Registry
18 stars 4 forks source link

Add support allowing sign-ins with Google accounts #109

Closed commonplace closed 8 years ago

commonplace commented 8 years ago

There's plenty I'd still love to see added, but this is probably number one -- if users could sign in using a Google (or Facebook or Amazon or Twitter, but really, Google is number one) account rather than making an account just for my wishlist... that'd be huge.

aaroneiche commented 8 years ago

This requires some pretty significant overhaul, but I am looking into an interim solution that could be deployed with minimal changes.

aaroneiche commented 8 years ago

So to clarify @commonplace, Are you looking for account creation and login with Google, or just for attaching Google accounts to existing Do Want accounts so you can long in with google instead?

commonplace commented 8 years ago

Yes to both, but I'll take what I can get!

aaroneiche commented 8 years ago

I've got login working. It requires an additional table. The hard stuff is making it easy for users to create a new account with it, or add a social login to their account, without breaking something.

Also, getting the UI to work everywhere. Anyway, progress is progressing.

commonplace commented 8 years ago

I like the progress!!!! Thank you so much!!

On Mon, Nov 16, 2015 at 12:28 PM, Aaron Eiche notifications@github.com wrote:

I've got login working. It requires an additional table. The hard stuff is making it easy for users to create a new account with it, or add a social login to their account, without breaking something.

Also, getting the UI to work everywhere. Anyway, progress is progressing.

— Reply to this email directly or view it on GitHub https://github.com/aaroneiche/do-want/issues/109#issuecomment-157109506.

commonplace commented 8 years ago

I actually decided to switch to Amazon for our wishlists, but I have changed my mind because Do-Want has several things Amazon doesn't. The biggest (to me) is the ability to reserve items without actually buying them immediately. I found several other shortcomings with Amazon's wishlist system, too.

So my mother-in-law who just can't remember her Do-Want password EVER will be able to logon using another account (Google, Facebook, whatever -- she manages to remember those, usually) and get with the program.

Super excited!

On Mon, Nov 16, 2015 at 9:22 PM, Kevin J. Wangler kevin@envail.com wrote:

I like the progress!!!! Thank you so much!!

On Mon, Nov 16, 2015 at 12:28 PM, Aaron Eiche notifications@github.com wrote:

I've got login working. It requires an additional table. The hard stuff is making it easy for users to create a new account with it, or add a social login to their account, without breaking something.

Also, getting the UI to work everywhere. Anyway, progress is progressing.

— Reply to this email directly or view it on GitHub https://github.com/aaroneiche/do-want/issues/109#issuecomment-157109506 .

aaroneiche commented 8 years ago

Unless she logs out of one of those services explicitly, she should be able to simply click the button and be logged in. You can also associate an account with multiple systems, so as long as she can remember the login for one of them, she should be okay. But if she remains logged into facebook or google, it really shouldn't be an issue. Just a button push (and that I hope to fix soon as well with a proper login cookie)

commonplace commented 8 years ago

Even better!! :)

On Tue, Nov 17, 2015 at 12:49 PM, Aaron Eiche notifications@github.com wrote:

Unless she logs out of one of those services explicitly, she should be able to simply click the button and be logged in. You can also associate an account with multiple systems, so as long as she can remember the login for one of them, she should be okay. But if she remains logged into facebook or google, it really shouldn't be an issue. Just a button push (and that I hope to fix soon as well with a proper login cookie)

— Reply to this email directly or view it on GitHub https://github.com/aaroneiche/do-want/issues/109#issuecomment-157450896.

aaroneiche commented 8 years ago

This has been implemented, working towards a release so people can actually use this. (commit 7f3bd080+)