search

aaroneiche / do-want

Do Want - Open Source Gift Registry
18 stars 4 forks source link

swap the images for reserve/release icons #61

Closed aaroneiche closed 11 years ago

aaroneiche commented 11 years ago

Original author: ke...@envail.com (December 05, 2012 16:55:25)

I'd like the list to show an UNLOCKED padlock if the item is NOT reserved, and show the LOCKED padlock icon when you reserve it. To me (and my wife), that is way more logical. You would see items on the list UNlocked (available) or locked (reserved). Right now, it's the opposite, which is how PHPGiftReg was.

Original issue: http://code.google.com/p/do-want/issues/detail?id=61

aaroneiche commented 11 years ago

From ke...@envail.com on December 05, 2012 17:02:10 I accomplished this by pointing the respective items to the other icon in the bootstrap.icons-large.css file (changed the "icon-lock" to "icon-unlock" and changed "icon-unlock" to "icon-lock"). If you decide not to change it for Do-Want, I'll just keep it this way on my own.

aaroneiche commented 11 years ago

From aaron.ei...@gmail.com on December 05, 2012 18:49:40 I think this is a matter of how you view what the icon is describing: A closed padlock does describe a "locked" thing, and the open padlock likewise describes "something accessible". I think the concept behind this is that the icons represent an action rather than a state. The closed padlock means "lock this", and likewise the open padlock means "unlock this".

aaroneiche commented 11 years ago

From ke...@envail.com on December 05, 2012 18:52:40 I understand the reasoning, and I'm sure that's why it was that way in PHPGiftReg as well. To us, it just seems illogical -- we think the icon should display its current state, not the action. But obviously it's a matter of opinion and preference. I've changed ours but I know others (yourself included) will disagree.

aaroneiche commented 11 years ago

From aaron.ei...@gmail.com on December 05, 2012 23:20:16 I imagine this could devolve into an argument about user interface design. Whatever you want it to represent is fine with me. One thing you should be aware of is that the title text associated with the icons is generated on the fly, this may be confusing to users. This will be alterable once localization is introduced (you can just change the text). As all other buttons represent an action to be taken, I lean towards the current implementation.

I'm going to close this issue for the time being. We may come back to it if we later provide a means of setting icons (which isn't out of the question).

aaroneiche commented 11 years ago

From ke...@envail.com on December 05, 2012 23:31:42 Not sure what you mean about the title text being generated on the fly. Even though I reversed the reserve/release icons, the text is still correct. In my case, when I hover over the open padlock, it says "Reserve Item", which is correct (for me). So it seems to work okay.

And definitely, this is your software. I appreciate you taking feedback, and understand that you can't implement every suggestion or make everyone happy. In this case, I "fixed it" myself and it's no problem at all. :)