search

aarongilly / obsidian-semantic-canvas-plugin

MIT License
66 stars 1 forks source link

Properties not updating when in the canvas that is made from 'Create canvas based on note' #4

Open Faeust opened 5 months ago

Faeust commented 5 months ago

When I turn a note into a canvas and have all of the properties in it, if I edit them, move them, or change anything, and try to either append or overwrite, nothing happens.

When I copy/paste the created canvas with all of the pieces into a new canvas and try to edit it - it still does not append or overwrite.

But if I make a new canvas and pull over the original note and anything I want to change and do it there it works.

(On a similar note, I wish I could edit the properties in the note itself and have the canvas-from-note update as well, not have to delete it and make another note as it messes up where I've moved things around).

Faeust commented 5 months ago

Some more info- when you make a canvas from a note that does not have any properties, and then you add them, it does update. It seems to be only in cases where you already have properties before creating the canvas that there's a problem and it won't update or change things.

aarongilly commented 3 months ago

Sorry, just now noticed these issues. I think I'm following your steps, but I'm unable to reproduce the issue.

If I create a Canvas from a note with some pre-existing properties on it, then from the newly created canvas I make changes & click the "Append note properties based on canvas" button, on my machine that is properly updating the original note.

I'm sorry you're having this trouble. That's one of the main use cases I built this thing for. I wonder if you've got some other plugin that's stoping this from working somehow? My development vault has only my plugin on it. :-/

Are you still having this issue?

Faeust commented 3 months ago

I will go back and see if the issues are still there when I can. I do have several other plug-ins and maybe you're right and it's one of those causing the issue. I'll let you know :) Thank you so much for looking into it!

aarongilly commented 3 months ago

Oh also I just noticed your parenthetical. I'm on a roll of not noticing things.

I could probably do something that would enable parts of that, although it may have some unintended side effects. I could definitely see utility in the idea. The issue would be not populating every possible link. The easiest/cleanest way to implement the function would be to:

  1. Find all the notes in the active canvas.
  2. Find all the keys for list-type properties in those notes
  3. Find cases where those keys already exist in the canvas for that property. Ensure the value of the connecting node is correct by overwriting whatever is there.
  4. ...and possibly create new nodes for keys that are on the note but aren't on the canvas already.

I'm going to add this to my "see what I can do about it" list for when I get back to developing on this. It won't be super soon, but my personal goal is before end of calendar year.

Faeust commented 3 months ago

Take your time! I love the plug-in and it's helped me immensely even with this 'issue.'

Faeust commented 2 months ago

Sorry, just now noticed these issues. I think I'm following your steps, but I'm unable to reproduce the issue.

If I create a Canvas from a note with some pre-existing properties on it, then from the newly created canvas I make changes & click the "Append note properties based on canvas" button, on my machine that is properly updating the original note.

I'm sorry you're having this trouble. That's one of the main use cases I built this thing for. I wonder if you've got some other plugin that's stoping this from working somehow? My development vault has only my plugin on it. :-/

Are you still having this issue?

I realized I never answered this question and unfortunatly I still am. I turned off all other community plugins and it still won't work that way. A new canvas with the same name will allow me to append it or change, but a canvas made from a note with existing links will not. I will continue to play with it and see if I can get it 'unstuck'

aarongilly commented 1 month ago

I doubt the issue would be fixed with the update I just pushed, but you might try it again.

Majofski commented 1 week ago

I am having this issue too. When I pull my notes into a canvas, it will not populate from the properties This is the yaml from two of these notes. Can you see why this is not working? I have checked to see if my use of variables with a space in it might be the problem (like communication field), but it is not; gives the same result, no population from notes. Had to make a screenshot as this interface interprets markdown and does not allow for the upload of md files

image