It looks like right now that for the type definition of BoundingFrame (code link) we have the x and y elements alluded to as the top and left coordinates, respectively. This is mainly due to the fact that we also have boundingCenterX and boundingCenterY included in the object.
But according to getFrame in Android (code link) we are setting x and y to be the exactCenter coordinates.
This appears to almost be a copy of what we are storing for boundingCenter*, and since the Rect object in Kotlin offer left and top properties (doc link) would it make more sense to swap to using those for x and y, respectively?
Edit: It's also worth noting that on iOS we appear to handle the calculation of x and y manually, thus converting them to be top and left, respectively (code link).
Hey, hey! Love the plugin! 🙏
It looks like right now that for the type definition of
BoundingFrame
(code link) we have thex
andy
elements alluded to as thetop
andleft
coordinates, respectively. This is mainly due to the fact that we also haveboundingCenterX
andboundingCenterY
included in the object.But according to
getFrame
in Android (code link) we are settingx
andy
to be theexactCenter
coordinates.This appears to almost be a copy of what we are storing for
boundingCenter*
, and since theRect
object in Kotlin offerleft
andtop
properties (doc link) would it make more sense to swap to using those forx
andy
, respectively?Edit: It's also worth noting that on iOS we appear to handle the calculation of
x
andy
manually, thus converting them to betop
andleft
, respectively (code link).