search

aarongustafson / jekyll-webmention_io

A Jekyll Plugin for rendering Webmentions via Webmention.io
https://aarongustafson.github.io/jekyll-webmention_io/
MIT License
139 stars 27 forks source link

Fix problem with ordered list markup creating invalid HTML #149

Closed dltj closed 1 year ago

dltj commented 3 years ago

Fixes https://github.com/aarongustafson/jekyll-webmention_io/issues/148

aarongustafson commented 3 years ago

I kept having Ruby/Jekyll issues when upgrading my Mac, so I have moved off of Jekyll and will not be working on this project anymore, going forward. I am going to flag this as won’t fix, but leave it open in case someone else wants to pick up the project from here.

fancypantalons commented 3 years ago

Honestly, I have a much bigger concern that we're getting untrusted, third party content in the form of webmentions, and we're passing it through a markdown parser. I need to look at the history and code flow, here, as, naively, that seems strange to me...

fancypantalons commented 1 year ago

I'm gonna close this PR as I believe the actual, proper fix, here, is to stop running webmention content through a markdown parser in the first place, as at least with webmention.io, we're gonna receive text or sanitized HTML, not markdown.

aarongustafson commented 1 year ago

Sounds good. The Markdown parsing predated HTML in the feed.

dltj commented 1 year ago

I'm gonna close this PR as I believe the actual, proper fix, here, is to stop running webmention content through a markdown parser in the first place, as at least with webmention.io, we're gonna receive text or sanitized HTML, not markdown.

Makes sense—thanks for your efforts, @fancypantalons.