Instead of threading the QNetworkReply success and failure callbacks through the Downloader class, I can just pass them through a capture-by value lambda.
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Tested on all three platforms, no functional difference from existing download flow.
Checklist:
[x] My code follows the style guidelines of this project (black for Python
code, .clang-format in the src/jyut-dict directory for C++)
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have translated my user-facing strings to all currently-supported languages
[x] I have made corresponding changes to the documentation
Description
Instead of threading the QNetworkReply success and failure callbacks through the
Downloader
class, I can just pass them through a capture-by value lambda.Type of change
How Has This Been Tested?
Tested on all three platforms, no functional difference from existing download flow.
Checklist:
black
for Python code,.clang-format
in thesrc/jyut-dict
directory for C++)