aaronhktan / jyut-dict

A free, open-source, offline Cantonese Dictionary for Windows, Mac, and Linux. Qt, SQLite. C++ and Python.
https://jyutdictionary.com
MIT License
126 stars 8 forks source link

#132: Remove std::any from Downloader class #154

Closed aaronhktan closed 8 months ago

aaronhktan commented 8 months ago

Description

Instead of threading the QNetworkReply success and failure callbacks through the Downloader class, I can just pass them through a capture-by value lambda.

Type of change

How Has This Been Tested?

Tested on all three platforms, no functional difference from existing download flow.

Checklist: