aaronhktan / jyut-dict

A free, open-source, offline Cantonese Dictionary for Windows, Mac, and Linux. Qt, SQLite. C++ and Python.

https://jyutdictionary.com

MIT License

122 stars 8 forks source link

#161: Use QString::fromStdString(x) instead of QString{x.c_str()} #162

Closed aaronhktan closed 6 months ago

aaronhktan commented 6 months ago

Description

Using QString::fromStdString() should be a little bit more efficient when converting from an std::string to a QString. (See here.)
Also replaces an instance of const std::string & with std::string_view.

Part of improvements as part of #161.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested on macOS.

Checklist:

[x] My code follows the style guidelines of this project (black for Python code, .clang-format in the src/jyut-dict directory for C++)
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have translated my user-facing strings to all currently-supported languages
[x] I have made corresponding changes to the documentation