search

aaronhurt / zfs-replicate

POSIX compliant shell script to manage ZFS snapshot replication locally, or between hosts.
69 stars 17 forks source link

add shfmt and shellcheck status checks #32

Closed aaronhurt closed 3 weeks ago

aaronhurt commented 3 weeks ago

This PR adds the shfmt and shellcheck status checks to improve code consistency and quality. Enforcing these checks will reduce variation and bugs in the codebase.

aaronhurt commented 3 weeks ago

@tschettervictor This is a work-in-progress branch for cleaning up the code and getting all the checks passing. While looking through I found some code that's clearly broken. I'll add line comments there as I'm not 100% sure what you were trying to do in those sections.

aaronhurt commented 3 weeks ago

If you could, I'd appreciate a second set of eyes and hands doing a line-by-line review of the code to ensure it functions as expected before we issue a new release. I have dinner plans this evening, but I might have some more time this weekend to do a bit more review.

tschettervictor commented 3 weeks ago

I can assure you each line has a purpose. I just have to get you to ask and I will tell. :)

aaronhurt commented 3 weeks ago

I'm going to abandon this PR but preserve the comments. I'm going to revert master back to the 0.7 release and then focus on the patch branch to get everything cleaned up for a release.

tschettervictor commented 3 weeks ago

Can we at least create a branch with the current script, to get to the ports repo? The script function fine as is, I tested in in all scenarios.

Then we can work on code cleanup.