search

aaronjanse / 3mux

Terminal multiplexer inspired by i3
MIT License
1.82k stars 46 forks source link

clear help bar when disabled #117

Closed aaronjanse closed 3 years ago

aaronjanse commented 3 years ago

Since the pane render area does not include the help bar line, the help bar wasn't being cleared when disabled via a shortcut.

To test this PR:

rm ~/.config/3mux/config.toml
go run *.go

Then type Alt+\ to disable the help bar. Observe that this PR immediately makes the help bar hidden after doing that shortcut.

aaronjanse commented 3 years ago

Yeah, using something like ESC[K would be much more efficient. The current problem is that we have to coordinate the movement of the global cursor. I'll open an issue for rendering optimizations. I think it would make sense to eventually special-case things like clearing entire lines or clearing an entire full-screen pane

aaronjanse commented 3 years ago

I'll merge this for now, since I think clearing an entire line efficiently would require refactoring the global renderer's queue/frame coordination