search

aaronjensen / eslintd-fix

Emacs minor-mode to automatically fix javascript with eslint_d.
64 stars 8 forks source link

Enclose the filename in quotes; otherwise the shell fails on filename… #14

Closed stormwatch closed 5 years ago

stormwatch commented 5 years ago

At least with Fish shell, if the js filename includes spaces, eslintd-fix call to the eslint_d binary will fail unless we enclose it in quotation marks. Would you please check if this fix doesn't break eslintd-fix for other shells? Thank you.

aaronjensen commented 5 years ago

@stormwatch thank you for your contribution! I think that using (shell-quote-argument filename) would work and be safer for all shells. Could you give that a shot and see if it works?

stormwatch commented 5 years ago

But of course! Good old shell-quote-argument works as expected.

aaronjensen commented 5 years ago

Great, thank you @stormwatch