search

aaronjensen / sass-media_query_combiner

MIT License
168 stars 16 forks source link

Fails with really large projects #3

Closed pearlchen closed 11 years ago

pearlchen commented 11 years ago

I tried your script with my current project that's clocking in at over 4,000 lines of compiled CSS. Media queries are scattered over 40 or so SCSS files.

It seems to just hang with no indication as to what might be causing it to not finish. (A smaller snippet of the same file does fine.)

At the moment, I won't be able to send you my CSS to reproduce since we're not publicly launched yet but am posting this issue here in case you have any thoughts on how to address this.

aaronjensen commented 11 years ago

Hi Pearl,

It uses a recursive regular expression which I belielve is the only place that it could theoretically hang. I have no idea what would cause that though.

One thing you could try is to do a "binary search" through by deleting the bottom half of the css and testing it. If it hangs, try deleting the bottom half of what is left over. If it doesn't hang, try running it on just the original bottom half, etc. The goal is to try and narrow down which part is causing it to hang. It could be an interaction between different rules in the file, which this technique wouldn't find as well.

You could also just wait until you're able to send me a repro and I can take a look.

pearlchen commented 11 years ago

Hey @aaronjensen, long overdue followup but we've successfully been able to incorporate your library into beta.telus.com to enable partial support for IE8!

I believe that issue was from a media query within a comment in our SCSS that was causing a few things to break. Works fine now.

Thanks again for this tool!

aaronjensen commented 11 years ago

Ahh.. that's an interesting case. I'll open a new bug for that just in case someone else hits it. Thanks!