search

aaronlifenghan / aaron-project-hlepor

hLEPOR: Language-independent Model for Machine Translation Evaluation with Reinforced Factors
https://aclanthology.org/W13-2253.pdf
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

failure with one-word sentence #2

Closed nicolabertoldi closed 5 years ago

nicolabertoldi commented 5 years ago

the code fails when source (and ref) contains just one word

with this error

Use of uninitialized value in string eq at .... line 227

It seems that at this line https://github.com/aaronlifenghan/aaron-project-hlepor/blob/992d182fc4a0c254fd06e172761204bd7f1d9d39/source%20code#L227

the array is queried for the second position even if just the text contains just one word.

poethan commented 5 years ago

It shall be ok with one word sentence.

poethan commented 5 years ago

here is the ongoing maintaining version https://github.com/poethan/LEPOR including hLEPOR

nicolabertoldi commented 5 years ago

Actually the score is computed; maybe they are only warnings. But I am not sure if it is correct

I tried to compare with score returned by the Inten.to API and there is a difference

In my toy case, your tool returns 0.5, while Inten.to PIA returns 0.508832387099159

Not sure if only a matter of precision; Is it possible to increase the precision in your software?

nicolabertoldi commented 5 years ago

I will try with the version you pointed.

I would suggest to make filenames parametric

poethan commented 5 years ago

that is good suggestion. I was planning to package the tool and make it easier for users. I used to have chats with some users including skype call for how to use it. :)

nicolabertoldi commented 5 years ago

I opened a new issue on the other version which seems the one you are maintaining.

nicolabertoldi commented 5 years ago

thanks for the offer of a chat maybe next week