search

aaronlord / laroute

Generate Laravel route URLs from JavaScript.
MIT License
794 stars 139 forks source link

Change collection type for Route Collections #105

Open sdonchez opened 3 years ago

sdonchez commented 3 years ago

Changes the collection type from RouteCollection to AbstractRouteCollection, which is a common ancestor of both RouteCollection and CompiledRouteCollection. Calls getRoutes to retrieve an iterable route collection instead of just passing the RouteCollection object, which enables the same functionality for both collection types.

It looks like the phpunit check for this isn't fully implemented, but I'm able to execute the laroute:generate command with these changes and all of my routes generate successfully.

sdonchez commented 3 years ago

@aaronlord is there anything I can do to help get this closed?