aaronn / django-rest-framework-passwordless

Passwordless Auth for Django REST Framework
MIT License
717 stars 156 forks source link

2018 Maintance Updates #14

Closed djstein closed 6 years ago

djstein commented 6 years ago
djstein commented 6 years ago

@jakeprem anything you want to weight in on?

djstein commented 6 years ago

I am attempting to update the .travis.yml and tox.ini files based on what is described here but need a bit of help!

djstein commented 6 years ago

@aaronn how do you feel about the switch to Django 2 aka Python 3 only?

aaronn commented 6 years ago

@djstein I'm cool with switching to Python 3 and Django 2

djstein commented 6 years ago

@aaronn got builds to pass on Python 3.5 and above, thoughts on removing 3.3, 3.4 from build?

aaronn commented 6 years ago

@djstein oops, sorry– just changed some stuff. yeah I don't mind going 3.6+ even

djstein commented 6 years ago

haha with my previous commit it worked without tox-travis should we use tox-travis or just standard tox? Edit: I am not familiar with tox-travis

aaronn commented 6 years ago

@djstein feel free to roll 9c08d8b back and take out tox-travis. thought I figured out what was causing the travis failures. I'm not really familiar with tox or travis.

djstein commented 6 years ago

so for the tox file: [tox] envlist = flake8-py3, py36, pypy do we also need to remove those and let the environment be decided by the travis python version

aaronn commented 6 years ago

@djstein not sure, you had 3.5+ working earlier right? let's just use whatever you had working there

aaronn commented 6 years ago

@djstein seems like it's passing fine?