aaronparker / evergreen

Create evergreen Windows image build pipelines with the latest version numbers and download URLs for common applications
http://stealthpuppy.com/evergreen/
MIT License
375 stars 64 forks source link

DevToys: Using Pre-release #700

Closed g3rhard closed 3 months ago

g3rhard commented 3 months ago

Hello,

Would like to discuss about this update, as from one hand - it's pre-release, but from other hand - it's offering on official website:

Current state:

 Workspaces  Get-EvergreenApp -Name "DevToys" | Where-Object { $_.Architecture -eq "x64" -and $_.Type -eq "exe" -and $_.Platform -eq "Windows" }

Version       : 2.0.1.0
Platform      : Windows
Architecture  : x64
Type          : exe
InstallerType : Default
Date          : 08/06/2024
Size          : 58292689
URI           : https://github.com/DevToys-app/DevToys/releases/download/v2.0.1.0/devtoys_win_x64.exe

Small changes to get the proper link to installer (thanks, that we can avoid *.msixbundle in this app). If you are not agree, I can create separate package for it - but I need to know, how to properly name it.

Best, Kirill

aaronparker commented 3 months ago

If you put the Update.Uri value back to https://api.github.com/repos/DevToys-app/DevToys/releases/latest, and keep the MatchFileTypes value as \\.exe$|\\.zip$|\\.msixbundle$, then the new installers will be picked up when v2 becomes the current release (i.e. taken out of beta)

g3rhard commented 3 months ago

Hey, thanks for the reply.

Totally agree, but I'd like to use version 2 as it has a proper installer, although it's still in "beta" phase. If you have concerns about this, I can make another version of this package and call it "DevToysBeta".

Thanks in advance for your help.

aaronparker commented 3 months ago

I don't want to make it a new app because it would then need to be removed or modified once 2.0 is released.

I can make an update to the module to allow you to run this:

Get-EvergreenApp -Name GitHubRelease -AppParams @{Uri="https://api.github.com/repos/DevToys-app/DevToys/releases"}

This app only allows this query at the moment, so it will require a small update:

Get-EvergreenApp -Name GitHubRelease -AppParams @{Uri="https://api.github.com/repos/DevToys-app/DevToys/releases/latest"}
g3rhard commented 3 months ago

Fully understand, and I can say, that this approach looks better than mine, I'm fine with using -AppParams in the calls. Could you let me know when I can expect to see this solution? Thanks so much!

aaronparker commented 3 months ago

I'll release a new version over the weekend.

g3rhard commented 3 months ago

If you put the Update.Uri value back to https://api.github.com/repos/DevToys-app/DevToys/releases/latest, and keep the MatchFileTypes value as \\.exe$|\\.zip$|\\.msixbundle$, then the new installers will be picked up when v2 becomes the current release (i.e. taken out of beta)

Changes regarding Update.Uri was reverted, all other changes left untouched.