aaronparker / vcredist

Lifecycle management for the Microsoft Visual C++ Redistributables
https://vcredist.com
MIT License
132 stars 17 forks source link

Update Import-VcConfigMgrApplication.ps1 #46

Closed jpewterbaugh closed 5 years ago

jpewterbaugh commented 5 years ago

I kept getting an error when running the script:

Get-Item : Cannot find path '\\' because it does not exist. At C:\Program Files\WindowsPowerShell\Modules\VcRedist\2.0.132\Public\Import-VcConfigMgrApplication.ps1:183 char:68

I isolated it to when the Deployment Type was being created in SCCM (version 1810). It's due to set-location on line 177 and get-item on line 183. Once I updated the code everything worked as expected.

Source: https://stackoverflow.com/questions/23574653/running-get-childitem-on-unc-path-works-in-powershell-but-not-in-powershell-run

Description

Please describe your pull request in detail.

Related Issue

This project only accepts pull requests related to open issues.

Please link to the issue here

Motivation and Context

Why is this change required? What problem does it solve?

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

aaronparker commented 5 years ago

Nice one. Will hopefully review and merge over the next couple of days