aaronpk / Slack-IRC-Gateway

Bridge Slack rooms to IRC channels
Other
34 stars 6 forks source link

Shortened Slack URLs need to be expanded on IRC #24

Closed Zegnat closed 1 year ago

Zegnat commented 3 years ago

Example message from tonight:

http://www.unmung.com/jsontoxoxo?url=https%3A%2F%2Fgranary.io%2Furl%3Finput%3Dhtml%[…]feed%253Dhttp%25253A%25252F%25252Fscripting.com%25252Frss.xml

The […] in the middle of the URL is added by Slack, for display purposes only. In Slack, hovering the link will show the full URL, and clicking will also open this expended version.

Screenshot: showing the expanded URL in Slack on hover.

The actual full link that was expected was: http://www.unmung.com/jsontoxoxo?url=https%3A%2F%2Fgranary.io%2Furl%3Finput%3Dhtml%26output%3Djsonfeed%26url%3Dhttp%253A%252F%252Fwww.unmung.com%252Ffeed%253Ffeed%253Dhttp%25253A%25252F%25252Fscripting.com%25252Frss.xml

It is this expanded URL that should end up on IRC. Currently it leads to links unusable by chatters on IRC, as well as broken links in logging (e.g. the IndieWeb Chat logs).

aaronpk commented 3 years ago

We'll need to find the docs from Slack on this to know where to find the full URL. I'd also like to track down a change log from slack to find out when this changed, since it didn't do this before.

jamietanna commented 3 years ago

I've seen this happening on my work Slack for at least a couple of months, if it helps - and I seem to remember seeing this at least a few weeks ago on the IndieWeb Slack

bkil commented 1 year ago

You probably need to use '$1' here

according to

aaronpk commented 1 year ago

Thank you, this was fixed in 84b905a95949f26976568aa3aec3d979eea6c61b