aaronpk / XRay

X-Ray returns structured data from any URL
https://xray.p3k.app
MIT License
90 stars 15 forks source link

Parsing h-feed in minified HTML5 page #65

Closed kaushalmodi closed 6 years ago

kaushalmodi commented 6 years ago

Hello,

I noticed that you updated php-mf2 on xray and so tried out http://xray.p3k.io/parse?url=https%3A%2F%2Fscripter.co%2F again.

But it is not yet detecting the p-name:

image

Should I expect the p-name value to show up as name element under the feed element? Or is the website update pending?

This is the relevant portion of my site source:

<div class="posts h-feed">
  <a class="u-url hide" href=https://scripter.co/></a>
  <a href=https://scripter.co/ class="u-author hide">Kaushal Modi</a>
  <p class="p-name hide">A Scripter&#39;s Notes Homepage
  <article class="summary h-entry">
  <header>

As a side: The h-entry of the first linked page in the h-feed has 2 in-reply-to's, but xray has detected only the first one -- page.

First occurrence:

<div class=reply>In reply to:
  <p>
    <a class="u-in-reply-to h-cite" rel=in-reply-to href=http://www.kevinmarks.com/fragmentions.html>http://www.kevinmarks.com/fragmentions.html</a>
</div>

Second occurrence:

<div class=reply>In reply to:
  <p>
    <a class="u-in-reply-to h-cite" rel=in-reply-to href=https://kartikprabhu.com/notes/fragmentioner>https://kartikprabhu.com/notes/fragmentioner</a>
</div>

Let me know if I should open a separate issue for this.


Update (second-half is most likely non-issue)

If I understand correctly, the summary happens to contain only the first in-reply-to, so only that is shown.. the parser hasn't yet jumped into the h-entry.. right?

Thanks!

kaushalmodi commented 6 years ago

I just checked https://pin13.net/mf2/?url=https%3A%2F%2Fscripter.co%2F, and there the h-feed > p-name is detected correctly. 🙌

image


So I am guessing that just the xray website update is pending? Sorry for the noise if so.

aaronpk commented 6 years ago

Yep your site looks good now! XRay doesn't return the "name" of any feeds right now. Looks good in the raw microformats parsed result though!

kaushalmodi commented 6 years ago

Thanks for confirming! Does this issue need to stay open?

aaronpk commented 6 years ago

Nope! No problem here!