aaronpk / XRay

X-Ray returns structured data from any URL
https://xray.p3k.app
MIT License
90 stars 15 forks source link

Quoted tweet replies not showing quoted tweet (in Monocle) #73

Closed skpy closed 6 years ago

skpy commented 6 years ago

I have a Granary feed of some Twitter users. When they quote reply to a tweet, the Granary feed shows the quoted tweet, but Monocle does not (nor does Indigenous for iOS, for what it's worth).

Sample tweet: https://twitter.com/miklb/status/1015014506651668480

Granary output:

<article class="h-entry">
  <span class="p-uid">tag:twitter.com:1015014506651668480</span>

  <time class="dt-published" datetime="2018-07-05T23:28:11+00:00">2018-07-05T23:28:11+00:00</time>

  <span class="p-author h-card">
    <data class="p-uid" value="tag:twitter.com:miklb"></data>
<data class="p-numeric-id" value="6187652"></data>
    <a class="p-name u-url" href="https://miklb.com">Michael Bishop</a>
    <span class="p-nickname">miklb</span>
    <img class="u-photo" src="https://pbs.twimg.com/profile_images/799821749386874880/X_vv7MnK.jpg" alt="" />
  </span>

  <a class="u-url" href="https://twitter.com/miklb/status/1015014506651668480">https://twitter.com/miklb/status/1015014506651668480</a>
  <div class="e-content p-name">

  Iā€™m so making this into a t-shirt
  </div>

<article class="u-quotation-of h-cite">
  <span class="p-uid">tag:twitter.com:1015005409726357504</span>

  <time class="dt-published" datetime="2018-07-05T22:52:02+00:00">2018-07-05T22:52:02+00:00</time>

  <span class="p-author h-card">
    <data class="p-uid" value="tag:twitter.com:gitlost"></data>
<data class="p-numeric-id" value="1240421984"></data>
    <a class="p-name u-url" href="https://twitter.com/gitlost">Developers Swearing</a>
    <span class="p-nickname">gitlost</span>
    <img class="u-photo" src="https://pbs.twimg.com/profile_images/3336578378/a60d4b744784d4ab05ee1846234e0708.jpeg" alt="" />
  </span>

  <a class="u-url" href="https://twitter.com/gitlost/status/1015005409726357504">https://twitter.com/gitlost/status/1015005409726357504</a>
  <div class="e-content p-name">

  Still can't git fer shit
  </div>

</article>

Monocle output:

screen shot 2018-07-05 at 8 15 18 pm

Indigenous for iOS output: indigenous-ios-quoted-reply

aaronpk commented 6 years ago

XRay has been updated to handle this, for HTML source (it already did when parsing an actual tweet directly). Now Aperture will be making this data available to clients. Next up is to update Monocle to actually show the quoted post.

aaronpk commented 6 years ago

Update: Monocle supports quotation-of now, so new posts should have the content!

skpy commented 6 years ago

šŸŽ‰ šŸŽ† Thanks!