aaronpk / indielogin.com

Sign in with your domain name
https://indielogin.com
MIT License
155 stars 25 forks source link

Can't log in via GitHub using IDN. #122

Open sh1boot opened 4 months ago

sh1boot commented 4 months ago

I get an error saying there was a 404 when I enter my hostname in Unicode. I guess that might imply that name resolution succeeded but the server received a GET which it expected to be puny-coded and it actually got the raw Unicode and failed to recognise them as the same thing.

I don't seem to have this problem when I use curl on my local system. I assume the server is behaving as it should. I can't see the whole error message in the indielogin error page, so I can't dig much further into that.

If I enter the punycode domain name then it succeeds in getting the page but then follows that back to GitHub to validate the link but it cannot match the Unicode reference on GitHub with the punycode string I used to log in.

Unicode: https://www.tīkōuka.dev/ Punycode: https://www.xn--tkuka-m3a3v.dev/

sh1boot commented 4 months ago

Just to confirm, I tried passing the Unicode domain to curl command line and it uses the punycode hostname in the headers. The error message reported by indelogin looks a bit cooked so it may not accurately reflect what's being sent out to the server. I don't know.