aaronpk / indielogin.com

https://indielogin.com

MIT License

155 stars 25 forks source link

Docker heroku deploy button #43

Closed Lewiscowles1986 closed 4 years ago

Lewiscowles1986 commented 5 years ago

A series of edits to enable heroku deploys from a button.

~supports multiple MySQL providers (tested on Heroku)~ [REMOVED]
brings local-dev docker-compose environment
~makes redis URL configurable (compatible with Heroku)~ [MOVED TO #46]
~adds healthcheck endpoint to verify can talk to mysql & redis (not schema check or OAUTH provider check)~ [MOVED TO #46]
~css frontend fix to stop horizontal scrollbars (footer margin)~ [MOVED TO #45]
~replaced short tags that do not output <? with <?php~ [MOVED TO #49]
This has been tested with multiple Heroku DB providers as well as locally in a docker + docker-compose local-dev environment

~Could do with a clean-up, test suite, change or removal of config.php~ [DONE]

Lewiscowles1986 commented 5 years ago

Local Docker homepage

Screenshot from 2019-08-17 22-34-52

Lewiscowles1986 commented 5 years ago

Heroku deploy homepage

Screenshot from 2019-08-17 22-30-41

Heroku deploy other pages

Screenshot from 2019-08-17 22-32-32

Screenshot from 2019-08-17 22-33-23

Screenshot from 2019-08-17 22-30-55

Lewiscowles1986 commented 5 years ago

I have not yet worked out the MySQL migrations needed to manage from a raw SQL file on Heroku. I have tested locally and you'll notice a Docker compose MySQL container option because of changes to MySQL auth, which are not yet in PHP PDO at the time of writing.

It's likely that heroku provider specific instructions will differ between vendors

Lewiscowles1986 commented 5 years ago

healthcheck & CSS changes have been removed and moved into their own PR

Lewiscowles1986 commented 5 years ago

For now this is blocked on the inclusion of 12-factor PR's #47 or a config.php commit (of which I'd strongly recommend one that uses ENV).

I've reduced it's size and functionality to provide a pick-and-mix style approach to docker and heroku setup. This is pretty much now only a local docker environment (with docker-compose) and a heroku deploy.

Lewiscowles1986 commented 4 years ago

I need to check this again before it's committed.

aaronpk commented 4 years ago

I've made the changes for config loading from environment variables so it should be possible now to finish this PR. I don't fully understand the current state of this PR though.

Lewiscowles1986 commented 4 years ago

Chopped into pieces. I'll test soon and get back to you 👍. Last I checked I was waiting on you to explore an alternative ENV loader