search

aaronpk / indielogin.com

Sign in with your domain name
https://indielogin.com
MIT License
149 stars 24 forks source link

IndieLogin does not imply http(s) when verifying GitHub profiles #84

Closed Craftplacer closed 10 months ago

Craftplacer commented 2 years ago

When using the domain name alone on the GitHub profile, IndieLogin fails authenticating because it expects a full URL. This behavior is probably unwanted because GitHub also implies https when only using the domain on the profile.

IndieLogin returns an error message like:

Your GitHub profile linked to domain but we were expecting to see https://domain/. Make sure you link to https://domain/ in your GitHub profile.

Furthermore it wasn't obvious at first that you had to link your site in your GitHub profile, because the setup instructions only detailed adding an <a> or <link>.

aaronpk commented 2 years ago

Just to clarify, do you mean in your GitHub account you had just the domain typed like this?

image

Also what instructions did you find that didn't mention the GitHub profile needs to have the link? The instructions here mention it: https://indielogin.com/setup#github

Craftplacer commented 2 years ago

Just to clarify, do you mean in your GitHub account you had just the domain typed like this?

Yup.

Also what instructions did you find that didn't mention the GitHub profile needs to have the link? The instructions here mention it: https://indielogin.com/setup#github

My bad, I flew over the instructions looking for code rather than text.

aaronpk commented 2 years ago

Thanks, that's helpful! I have seen this error before and wasn't sure what was causing it! I'll update this to handle that case!