search

aaronpowell / db.js

db.js is a wrapper for IndexedDB to make it easier to work against
http://aaronpowell.github.com/db.js/
MIT License
820 stars 142 forks source link

Add blocked event handler to open() and delete() (with docs and tests), #160

Closed brettz9 closed 8 years ago

brettz9 commented 8 years ago

allowing additional "resume" promise property for user to easily resume promise chain (if blocking undone by closing old db connection); Cache server by version as well as name to allow upgrades of same name (and document); Avoid apparently broken saucelabs directive in grunt processing; Minor: Utilize forEach over for loop; Minor: Replace "magic" numbers with descriptive vars. in open() testing Minor: Clarify delete testing by moving db opening to beforeEach (and add some content)

I recommend starting with the README as the main added features are described there.

brettz9 commented 8 years ago

Note also that I have not updated dist/ in case my copy is still being generated differently from yours.

aaronpowell commented 8 years ago

I'm going to have to have a look at this in more depth outside of work

brettz9 commented 8 years ago

Yes, you are right--fixed, along with removing a code comment which was redundant with an explanation given elsewhere in the README.

brettz9 commented 8 years ago

Done. And yeah, I hear you about leaving in code annoyances as effective reminders. :)

aaronpowell commented 8 years ago

I'm actually close to getting the saucelabs integration working again, once i do that I'll see about this PR :smile:

brettz9 commented 8 years ago

I've integrated your changes into this PR, but locally and here, I'm having trouble with grunt-cli and the Sauce labs key. Since I can see the key, without having looked at any of this carefully, I wonder whether the issue may be that it is not being encrypted (as per the discussion at the bottom of https://saucelabs.com/javascript/jasmine-js ).

aaronpowell commented 8 years ago

So the value in the travis.yml file is my enrypted key and not one that I'm going to be sharing around :wink:. You can either sign up for a Sauce Labs account (they have an open source account) or rely on travis-ci to do the notice.

aaronpowell commented 8 years ago

Oh curious, the PR doesn't seem to have the key loaded. Wonder why that is...

aaronpowell commented 8 years ago

https://docs.travis-ci.com/user/pull-requests#Security-Restrictions-when-testing-Pull-Requests - that's why the build failed. Now to work out how to handle that...

Will have a look at these two today though